Review Request 112188: Don't delete LogsImporter thread while it's still running

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112188/
-----------------------------------------------------------

(Updated Aug. 22, 2013, 12:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Description
-------

When LogsImporter is deleted, it just deletes the importer thread even when it's running, which will obviously crash.

This patch adds a safety guard (calling QThread::wait() before deleting it) and a method to stop the thread prematurely so that we don't wait() for the entire import to finish (just for current document to finish). 


Diffs
-----

  KTp/logs-importer.cpp 926d265 
  KTp/logs-importer-private.h 06c9c0d 
  KTp/logs-importer-private.cpp 7275b07 

Diff: http://git.reviewboard.kde.org/r/112188/diff/


Testing
-------


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130822/d8a4b3e1/attachment.html>