Review Request 112188: Don't delete LogsImporter thread while it's still running

[Dan Vrátil]

> On Aug. 21, 2013, 7:22 p.m., David Edmundson wrote:
> > KTp/logs-importer-private.cpp, line 383
> > <http://git.reviewboard.kde.org/r/112188/diff/1/?file=183851#file183851line383>
> >
> >     I don't understand why we can't just check m_shouldStop here.
> >     
> >     Needs documenting at least.

We could, but I thought that we could at least finish writing the output file.


> On Aug. 21, 2013, 7:22 p.m., David Edmundson wrote:
> > KTp/logs-importer.cpp, line 39
> > <http://git.reviewboard.kde.org/r/112188/diff/1/?file=183852#file183852line39>
> >
> >     do we still need to delete d?
> >

Both are QObjects and LogsImporter is a parent of Private, so Qt should take care of it.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112188/#review38292
-----------------------------------------------------------


On Aug. 21, 2013, 6:18 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112188/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2013, 6:18 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> When LogsImporter is deleted, it just deletes the importer thread even when it's running, which will obviously crash.
> 
> This patch adds a safety guard (calling QThread::wait() before deleting it) and a method to stop the thread prematurely so that we don't wait() for the entire import to finish (just for current document to finish). 
> 
> 
> Diffs
> -----
> 
>   KTp/logs-importer-private.h 06c9c0d 
>   KTp/logs-importer-private.cpp 7275b07 
>   KTp/logs-importer.cpp 926d265 
> 
> Diff: http://git.reviewboard.kde.org/r/112188/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130821/33e73c5b/attachment.html>