Review Request 112005: KTp Logger

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112005/
-----------------------------------------------------------

(Updated Aug. 13, 2013, 9:49 p.m.)


Review request for Telepathy.


Description
-------

Hi guys,

on Akademy we discussed having our own logger that would provide abstraction 
over TpLoggerQt (and possibly other backends).

I've just pushed tp-logger branch in ktp-common-internals, which introduces 
KTp Logger - a library with API similar to what TpLoggerQt has and a plugin-
based design. There's already tplogger plugin which provides integration with 
Telepathy Logger via TpLoggerQt. TpLoggerQt is still just an optional 
dependency - without it the plugin will be disabled at build time.

For Windows, there also ktp-winlogger utility, which is an extremely super 
simple logger which stores logs into SQLite database and of course there's a 
plugin that provides integration with KTp Logger. It's automatically enabled 
on Windows, on Linux pass -DENABLE_WINLOGGER=TRUE to CMake. It works on Linux 
too :-)

In ktp-text-ui there is a ktplogger branch with logviewer completely ported to 
KTp Logger, so you can even test that it works :-) chat-ui and other 
components still have to be ported.


Diffs (updated)
-----

  KTp/Logger/log-manager-private.h PRE-CREATION 
  KTp/Logger/log-entity.cpp PRE-CREATION 
  KTp/Logger/log-entity.h PRE-CREATION 
  KTp/Logger/ktp_logger_plugin.desktop PRE-CREATION 
  KTp/Logger/abstract-logger-plugin.cpp PRE-CREATION 
  KTp/Logger/abstract-logger-plugin.h PRE-CREATION 
  KTp/Logger/CMakeLists.txt PRE-CREATION 
  KTp/CMakeLists.txt b514418db0da4ba41c13cbaea3591cba6b21ad5d 
  KTp/Logger/log-manager.h PRE-CREATION 
  KTp/Logger/log-manager.cpp PRE-CREATION 
  KTp/Logger/log-message.h PRE-CREATION 
  KTp/Logger/log-message.cpp PRE-CREATION 
  KTp/Logger/log-search-hit.h PRE-CREATION 
  KTp/Logger/log-search-hit.cpp PRE-CREATION 
  KTp/Logger/pending-logger-dates-impl.h PRE-CREATION 
  KTp/Logger/pending-logger-dates-impl.cpp PRE-CREATION 
  KTp/Logger/pending-logger-dates.h PRE-CREATION 
  KTp/Logger/pending-logger-dates.cpp PRE-CREATION 
  KTp/Logger/pending-logger-entities-impl.h PRE-CREATION 
  KTp/Logger/pending-logger-entities-impl.cpp PRE-CREATION 
  KTp/Logger/pending-logger-entities.h PRE-CREATION 
  KTp/Logger/pending-logger-entities.cpp PRE-CREATION 
  KTp/Logger/pending-logger-logs-impl.h PRE-CREATION 
  KTp/Logger/pending-logger-logs-impl.cpp PRE-CREATION 
  KTp/Logger/pending-logger-logs.h PRE-CREATION 
  KTp/Logger/pending-logger-logs.cpp PRE-CREATION 
  KTp/Logger/pending-logger-operation.h PRE-CREATION 
  KTp/Logger/pending-logger-operation.cpp PRE-CREATION 
  KTp/Logger/pending-logger-search-impl.h PRE-CREATION 
  KTp/Logger/pending-logger-search-impl.cpp PRE-CREATION 
  KTp/Logger/pending-logger-search.h PRE-CREATION 
  KTp/Logger/pending-logger-search.cpp PRE-CREATION 
  KTp/Logger/plugins/CMakeLists.txt PRE-CREATION 
  KTp/Logger/plugins/tplogger/CMakeLists.txt PRE-CREATION 
  KTp/Logger/plugins/tplogger/ktploggerplugin_tplogger.desktop.cmake PRE-CREATION 
  KTp/Logger/plugins/tplogger/pending-tp-logger-dates.h PRE-CREATION 
  KTp/Logger/plugins/tplogger/pending-tp-logger-dates.cpp PRE-CREATION 
  KTp/Logger/plugins/tplogger/pending-tp-logger-entities.h PRE-CREATION 
  KTp/Logger/plugins/tplogger/pending-tp-logger-entities.cpp PRE-CREATION 
  KTp/Logger/plugins/tplogger/pending-tp-logger-logs.h PRE-CREATION 
  KTp/Logger/plugins/tplogger/pending-tp-logger-logs.cpp PRE-CREATION 
  KTp/Logger/plugins/tplogger/pending-tp-logger-search.h PRE-CREATION 
  KTp/Logger/plugins/tplogger/pending-tp-logger-search.cpp PRE-CREATION 
  KTp/Logger/plugins/tplogger/tp-logger-plugin.h PRE-CREATION 
  KTp/Logger/plugins/tplogger/tp-logger-plugin.cpp PRE-CREATION 
  KTp/Logger/plugins/tplogger/utils.h PRE-CREATION 
  KTp/Logger/plugins/tplogger/utils.cpp PRE-CREATION 
  KTp/Logger/plugins/winlogger/CMakeLists.txt PRE-CREATION 
  KTp/Logger/plugins/winlogger/logger/CMakeLists.txt PRE-CREATION 
  KTp/Logger/plugins/winlogger/logger/KTp.WinLogger.client PRE-CREATION 
  KTp/Logger/plugins/winlogger/logger/db.h PRE-CREATION 
  KTp/Logger/plugins/winlogger/logger/db.cpp PRE-CREATION 
  KTp/Logger/plugins/winlogger/logger/logger.h PRE-CREATION 
  KTp/Logger/plugins/winlogger/logger/logger.cpp PRE-CREATION 
  KTp/Logger/plugins/winlogger/logger/main.cpp PRE-CREATION 
  KTp/Logger/plugins/winlogger/logger/observer.h PRE-CREATION 
  KTp/Logger/plugins/winlogger/logger/observer.cpp PRE-CREATION 
  KTp/Logger/plugins/winlogger/logger/org.freedesktop.Telepathy.Client.KTp.WinLogger.service.in PRE-CREATION 
  KTp/Logger/plugins/winlogger/logger/org.freedesktop.Telepathy.KTp.WinLogger.service.in PRE-CREATION 
  KTp/Logger/plugins/winlogger/plugin/CMakeLists.txt PRE-CREATION 
  KTp/Logger/plugins/winlogger/plugin/ktploggerplugin_winlogger.desktop.cmake PRE-CREATION 
  KTp/Logger/plugins/winlogger/plugin/pending-win-logger-dates.h PRE-CREATION 
  KTp/Logger/plugins/winlogger/plugin/pending-win-logger-dates.cpp PRE-CREATION 
  KTp/Logger/plugins/winlogger/plugin/pending-win-logger-entities.h PRE-CREATION 
  KTp/Logger/plugins/winlogger/plugin/pending-win-logger-entities.cpp PRE-CREATION 
  KTp/Logger/plugins/winlogger/plugin/pending-win-logger-logs.h PRE-CREATION 
  KTp/Logger/plugins/winlogger/plugin/pending-win-logger-logs.cpp PRE-CREATION 
  KTp/Logger/plugins/winlogger/plugin/pending-win-logger-search.h PRE-CREATION 
  KTp/Logger/plugins/winlogger/plugin/pending-win-logger-search.cpp PRE-CREATION 
  KTp/Logger/plugins/winlogger/plugin/win-logger-plugin.h PRE-CREATION 
  KTp/Logger/plugins/winlogger/plugin/win-logger-plugin.cpp PRE-CREATION 
  KTp/message-processor.h 8ce92b2a91c2839167ea19885166cb4e878333f0 
  KTp/message-processor.cpp e045d7bf335bdf9b8ec9b975e147f13ef8575acb 
  KTp/message.h 29536168c5e140f02c67c16fd705c66e9753fe0e 
  KTp/message.cpp 36ea23479034b48e8e1f580625de855af64faf34 

Diff: http://git.reviewboard.kde.org/r/112005/diff/


Testing
-------


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130813/ddabcf02/attachment.html>