Review Request 112043: Removal of 'Typing...' in chat window title to avoid confusing UX

[Daniel Cohen]

> On Aug. 12, 2013, 11:59 p.m., David Edmundson wrote:
> > app/chat-window.cpp, line 644
> > <http://git.reviewboard.kde.org/r/112043/diff/1/?file=178415#file178415line644>
> >
> >     I'm not sure you want to remove this line. (the first of these 2)
> >     
> >     This will stop it updating the window icon I think.

Ah, I have icons turned off on Kwin, so missed that.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112043/#review37629
-----------------------------------------------------------


On Aug. 12, 2013, 11:56 p.m., Daniel Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112043/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 11:56 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> When a user is talking to multiple people, it is confusing to have 'Typing... Bob', when it's actually Fred in another tab who is typing. 
> 
> The presence of the both the chat tab status-icon change combined with the tab name text colour change is sufficient to denote activity and removes this confusion which is exacerbated with the more chat tabs that you have open.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.cpp d829125 
>   app/chat-window.h 3a5b6ba 
> 
> Diff: http://git.reviewboard.kde.org/r/112043/diff/
> 
> 
> Testing
> -------
> 
> Tabs still change icon and colour upon user typing/message received.
> 
> 
> Thanks,
> 
> Daniel Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130813/fc534bc9/attachment-0001.html>