Review Request 111727: accounts-kcm gui code for steam plugin of libpurple

[Martin Klapetek]

> On Aug. 8, 2013, 8:43 a.m., Martin Klapetek wrote:
> > I briefly looked into Steam licensing and stuff and this might be interesting:
> > 
> > "You agree, and Valve grants you a license, to implement the Valve name(s), logo(s), and links to Valve (the "Valve Brand & Links") on any Web page incorporating the Steam Web API"
> > 
> > -- http://steamcommunity.com/dev/apiterms
> > 
> > AFAIU the pidgin plugin actually uses the web API (it uses OAuth, which is part of the "Web API"), so this should hold. And if that is the case, we also need to comply to
> > 
> > "Each page that uses the Steam Web API must contain a link to http://steampowered.com with the text "Powered by Steam"."
> > 
> > -- http://steamcommunity.com/dev
> > 
> > ...although we're not a website, but we are incorporating Steam API. 
> > 
> > Conclusion: We could use Steam icons and we need to add "Steam powered" in the dialog. Looks pretty ok to me :)
> > 
> > (I'm happy if someone can double check)
> 
> David Edmundson wrote:
>     No matter what we're actually allowed I still think Debian packagers will moan that they can't distribute it as FOSS. There was an idea of making some sort of "restricted icons" package in the Skype icons thread (not on our ML) we should chase that up.
>     
>     
>     (Also technically we're not using the Steam API. A completely separate program is - and communicating over DBus.)
>

> Debian packagers will moan that they can't distribute it as FOSS

I believe we shouldn't succomb to the needs of one distribution. Plus they can patch the icon out on package level if really needed/wanted.

> technically we're not using the Steam API

Their terms say "incorporating" which according to dictionary means "Take in (something) as part of a whole; include.", which is what we're doing imho - including a library to enable communication with their API. Still, I think putting a link in the dialog is not that much.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111727/#review37322
-----------------------------------------------------------


On Aug. 8, 2013, 12:01 a.m., Daniel Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111727/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2013, 12:01 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Gui code for accounts-kcm that gives the steam-mobile plugin of libpurple a native/shiny look. I Didn't include the https tickbox because it seems to not function.
> 
> 
> Diffs
> -----
> 
>   data/profiles/steam.profile PRE-CREATION 
>   plugins/haze/CMakeLists.txt ebc28c6 
>   plugins/haze/haze-account-ui-plugin.cpp e618518 
>   plugins/haze/haze-steam-account.h PRE-CREATION 
>   plugins/haze/haze-steam-account.cpp PRE-CREATION 
>   plugins/haze/steam-main-options-widget.h PRE-CREATION 
>   plugins/haze/steam-main-options-widget.cpp PRE-CREATION 
>   plugins/haze/steam-main-options-widget.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111727/diff/
> 
> 
> Testing
> -------
> 
> Created new account and logged in successfully.
> 
> 
> File Attachments
> ----------------
> 
> KCM (added by Dave on Daniel's behalf)
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/07/28/steam1.png
> 
> 
> Thanks,
> 
> Daniel Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130808/a13dfa02/attachment-0001.html>