Review Request 111727: accounts-kcm gui code for steam plugin of libpurple

Daniel Cohen analoguecolour at gmail.com
Wed Aug 7 23:57:44 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111727/
-----------------------------------------------------------

(Updated Aug. 7, 2013, 11:57 p.m.)


Review request for Telepathy.


Changes
-------

added suitable icon (although a steam specific one in the future would be nice). Refactored account gui and added .profile so it reads as Steam Chat.


Description
-------

Gui code for accounts-kcm that gives the steam-mobile plugin of libpurple a native/shiny look. I Didn't include the https tickbox because it seems to not function.


Diffs (updated)
-----

  data/profiles/steam.profile PRE-CREATION 
  plugins/haze/CMakeLists.txt ebc28c6 
  plugins/haze/haze-account-ui-plugin.cpp e618518 
  plugins/haze/haze-steam-account.h PRE-CREATION 
  plugins/haze/haze-steam-account.cpp PRE-CREATION 
  plugins/haze/steam-main-options-widget.h PRE-CREATION 
  plugins/haze/steam-main-options-widget.cpp PRE-CREATION 
  plugins/haze/steam-main-options-widget.ui PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111727/diff/


Testing
-------

Created new account and logged in successfully.


File Attachments
----------------

KCM (added by Dave on Daniel's behalf)
  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/28/steam1.png


Thanks,

Daniel Cohen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130807/435128d4/attachment.html>


More information about the KDE-Telepathy mailing list