Review Request 110236: Remove pointless call to model index parent to count top level items
Daniele E. Domenichelli
daniele.domenichelli at gmail.com
Mon Apr 29 06:57:04 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110236/#review31725
-----------------------------------------------------------
global-presence-chooser.cpp
<http://git.reviewboard.kde.org/r/110236/#comment23638>
Isn't QModelIndex() and invalid index?
- Daniele E. Domenichelli
On April 29, 2013, 1:56 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110236/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 1:56 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Remove pointless call to model index parent to count top level items
>
> BUG: 304085
>
>
> Diffs
> -----
>
> global-presence-chooser.cpp f5d59399a904195121ebac7266bef4176ac82bfb
>
> Diff: http://git.reviewboard.kde.org/r/110236/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130429/59ca7c6d/attachment.html>
More information about the KDE-Telepathy
mailing list