Review Request 110227: [ktp-contact-list] Now playing shouldn't be disabled on pause

Ian Monroe ian.monroe at gmail.com
Mon Apr 29 02:33:49 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110227/
-----------------------------------------------------------

(Updated April 29, 2013, 2:33 a.m.)


Review request for Telepathy and Martin Klapetek.


Changes
-------

Fixed the issues identified by David.


Description
-------

Now playing shouldn't be disabled on pause

Fix requires corresponding commit in ktp-kded-module https://git.reviewboard.kde.org/r/110228/
Needed to separate things done for every presence change
from those actions only to be done on user-initiated presence changes


Diffs (updated)
-----

  global-presence-chooser.h 678681c92afcbfcc85245b809bd29e84477eacfa 
  global-presence-chooser.cpp f5d59399a904195121ebac7266bef4176ac82bfb 
  presence-model.h 2ce652ffe50197e652e99f7190b3a988f87cb4e3 

Diff: http://git.reviewboard.kde.org/r/110227/diff/


Testing
-------


Thanks,

Ian Monroe

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130429/61290009/attachment.html>


More information about the KDE-Telepathy mailing list