Review Request 110016: Expose senderId, senderAlias and senderAvatar properties in MessageModel

Commit Hook null at kde.org
Thu Apr 18 01:30:04 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110016/#review31229
-----------------------------------------------------------


This review has been submitted with commit a031a1870b7048a17dfc5717eca786da374cafb6 by David Edmundson to branch master.

- Commit Hook


On April 14, 2013, 9:55 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110016/
> -----------------------------------------------------------
> 
> (Updated April 14, 2013, 9:55 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Expose senderId, senderAlias and senderAvatar properties in MessageModel
> 
> Also remove rather ambiguous UserRole which used to have sender alias
> 
> This does break the declarative API, but not the main lib.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/messages-model.h 83d879265a966740beee577560d57384b8eec83c 
>   KTp/Declarative/messages-model.cpp 2c15c276534b1cb0d869e17f6124261c6ccf05dd 
> 
> Diff: http://git.reviewboard.kde.org/r/110016/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130418/c1df4e3b/attachment.html>


More information about the KDE-Telepathy mailing list