Review Request 109834: Expose sender in KTp::Message

Commit Hook null at kde.org
Thu Apr 18 01:29:59 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109834/#review31227
-----------------------------------------------------------


This review has been submitted with commit 5e02ba58f2186de6c354e140267585ac9d058d79 by David Edmundson to branch master.

- Commit Hook


On April 14, 2013, 7:01 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109834/
> -----------------------------------------------------------
> 
> (Updated April 14, 2013, 7:01 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Expose senderAvatar in KTp::Message
> 
> Simplify code and make it less possible to crash.
> Store the contactPtr of the sender where possible to avoid storing the samepixmap many times.
> 
> Also fix message direction of log messages.
> 
> 
> Diffs
> -----
> 
>   KTp/message.h 812c90e6ddf6d77af9ffab1f866be57fe95419aa 
>   KTp/message.cpp cbb91346bc174ebbab279b2eae732a1e322b5a7e 
> 
> Diff: http://git.reviewboard.kde.org/r/109834/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130418/1e22b412/attachment.html>


More information about the KDE-Telepathy mailing list