Review Request 110061: Two lines high initial size for the input field

[Thomas Pfeiffer]

> On April 17, 2013, 9:12 a.m., Alin M Elena wrote:
> > lib/chat-text-edit.cpp, line 81
> > <http://git.reviewboard.kde.org/r/110061/diff/1/?file=139155#file139155line81>
> >
> >     do you plan to make this two configurable? allow the user to set how many lines wants?
> >     also should not you have two linespacings?
> >
> 
> Thomas Pfeiffer wrote:
>     Please do _not_ make this configurable. Starting with two lines makes sense to make it clear ot users that this is a multi-line edit box, but we do not need a user-configurable value because we use an auto-expanding box. I know that Pidgin was forked over this issue, but I think users will adjust to auto-expanding boxes over time.
> 
> Martin Klapetek wrote:
>     I don't think so, the logic is "twice the size of the font + the space between lines", which seems ok. Also I don't want to see this configurable. We can't provide configuration options for every single piece of our UIs.
> 
> Róbert Szókovács wrote:
>     I wanted to give exactly these answers, thanks!
> 
> Alin M Elena wrote:
>     Thomas and how having it configurable prevents the auto-expanding?
>     Martin... of course but remember the debate we had about 2 lines vs 1 line and how people argued for one or another... giving them the chance to configure how many lines want makes sense... 
>     the two line spaces... one in between the two lines and another one between the lower line and border... anyhow this is a detail we can change later if feels bad... 
>     I will say ship it now and keep the discussion open on configuration.

Making it configurable of course does not prevent auto-expansion, but I think that auto-expansion makes configurability of default height unnecessary.
Yes, people debate about a whole lot of things, but most of the time it's just that they want to keep things like they are personally used to. Neither a one-line default nor a two-line default are going to cause any real trouble for anyone, the two-line default just has the slight advantage mentioned above.
Yes, some people will complain, but if someone quits using KTp over an extra line in the edit box, that user wasn't really convinced of KTp anyway. I am for giving the option to turn _features_ which are useful to some users but annoying to others on and off, but this is not a feature, this is a little cosmetic detail. And if we make every little cosmetic detail configurable (because there are always people vocally defending both ways), we end up with KDE3-style config dialogs.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110061/#review31196
-----------------------------------------------------------


On April 17, 2013, 9:02 a.m., Róbert Szókovács wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110061/
> -----------------------------------------------------------
> 
> (Updated April 17, 2013, 9:02 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This patch makes the input field's minimal size to lines high.
> 
> 
> Diffs
> -----
> 
>   lib/chat-text-edit.cpp 20055c9 
> 
> Diff: http://git.reviewboard.kde.org/r/110061/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Róbert Szókovács
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130417/020c3b59/attachment-0001.html>