Review Request 110060: Add configuration for additional charsets in ICQ

Martin Klapetek martin.klapetek at gmail.com
Wed Apr 17 09:32:28 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110060/#review31202
-----------------------------------------------------------

Ship it!


Very nice!

- Martin Klapetek


On April 17, 2013, 8:42 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110060/
> -----------------------------------------------------------
> 
> (Updated April 17, 2013, 8:42 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This patch is based on this review https://git.reviewboard.kde.org/r/106915, but the OP does no seem to be active or interested anymore, so let's finally get rid of it.
> 
> The patch is based on Kopete - the list of supported encodings is copied from there and when adding a new ICQ account a charset preselected based on your locale settings.
> 
> 
> This addresses bug 306401.
>     http://bugs.kde.org/show_bug.cgi?id=306401
> 
> 
> Diffs
> -----
> 
>   plugins/haze/icq-server-settings-widget.h cb581d0 
>   plugins/haze/icq-server-settings-widget.cpp d99b092 
>   plugins/haze/icq-server-settings-widget.ui 6fe0a0a 
> 
> Diff: http://git.reviewboard.kde.org/r/110060/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130417/cde125f8/attachment.html>


More information about the KDE-Telepathy mailing list