Review Request 110061: Two lines high initial size for the input field

[Thomas Pfeiffer]

> On April 17, 2013, 9:12 a.m., Alin M Elena wrote:
> > lib/chat-text-edit.cpp, line 81
> > <http://git.reviewboard.kde.org/r/110061/diff/1/?file=139155#file139155line81>
> >
> >     do you plan to make this two configurable? allow the user to set how many lines wants?
> >     also should not you have two linespacings?
> >

Please do _not_ make this configurable. Starting with two lines makes sense to make it clear ot users that this is a multi-line edit box, but we do not need a user-configurable value because we use an auto-expanding box. I know that Pidgin was forked over this issue, but I think users will adjust to auto-expanding boxes over time.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110061/#review31196
-----------------------------------------------------------


On April 17, 2013, 9:02 a.m., Róbert Szókovács wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110061/
> -----------------------------------------------------------
> 
> (Updated April 17, 2013, 9:02 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This patch makes the input field's minimal size to lines high.
> 
> 
> Diffs
> -----
> 
>   lib/chat-text-edit.cpp 20055c9 
> 
> Diff: http://git.reviewboard.kde.org/r/110061/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Róbert Szókovács
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130417/9817ce7e/attachment.html>