Review Request 110041: Middlemouse paste in chat area handled

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110041/#review31153
-----------------------------------------------------------

Ship it!


Nice patch and long missing feature, thanks! Couple mostly coding style nitpicks below, otherwise looks good.


lib/adium-theme-view.h
<http://git.reviewboard.kde.org/r/110041/#comment23160>

    Coding style - QMouseEvent* ev -> QMouseEvent *ev



lib/adium-theme-view.cpp
<http://git.reviewboard.kde.org/r/110041/#comment23161>

    Coding style - QMouseEvent* event -> QMouseEvent *event



lib/adium-theme-view.cpp
<http://git.reviewboard.kde.org/r/110041/#comment23162>

    You might want to check if event->modifiers() are empty; also coding style - the bracket goes to the same line as the if, eg. if () {
    
    



lib/chat-text-edit.cpp
<http://git.reviewboard.kde.org/r/110041/#comment23163>

    includes should be in the "nice form", eg. <QApplication>, <QClipboard> etc



lib/chat-text-edit.cpp
<http://git.reviewboard.kde.org/r/110041/#comment23164>

    indentation is 4 spaces


- Martin Klapetek


On April 16, 2013, 11:52 a.m., Róbert Szókovács wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110041/
> -----------------------------------------------------------
> 
> (Updated April 16, 2013, 11:52 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Makes the chat area in ktp-text-ui accept middlemouse pastes and paste it into the input field. Idea lifted from konversation.
> 
> 
> Diffs
> -----
> 
>   lib/chat-widget.cpp 612fb87 
>   lib/chat-text-edit.cpp 305455c 
>   lib/chat-text-edit.h 11d428e 
>   lib/adium-theme-view.h 70618f6 
>   lib/adium-theme-view.cpp 361cd6d 
> 
> Diff: http://git.reviewboard.kde.org/r/110041/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Róbert Szókovács
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130416/b6908b6f/attachment.html>