Review Request 110009: change signal used from stateChanged to toggled / see reviewboard

[Stefan Eggers]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110009/
-----------------------------------------------------------

(Updated April 16, 2013, 10 a.m.)


Review request for Telepathy.


Changes
-------

- Changed to use signal toggled(bool) instead of stateChanged(int). (see Dan's comment on this)
- Corrected parameter names of newly added methods in behavior-config.h to be consistent with behavior-config.cpp.
- Expanded a comment to also explain the newly added behavior.


Summary (updated)
-----------------

change signal used from stateChanged to toggled / see reviewboard


Description (updated)
-------

change signal used from stateChanged to toggled / see reviewboard


add option to show me typing (to others) and others typing (to me)

Adding two configuration options which allow to select if:

- Others get shown that I am typing.
- I get shown that others are typing.

This add the options wished for in bug 282201.


This addresses bug 282201.
    http://bugs.kde.org/show_bug.cgi?id=282201


Diffs (updated)
-----

  app/chat-window.cpp 17300d81f2fff8d2604a1d493fbc8b30cf9e169c 
  config/behavior-config.h fa0f68615f8bb85c108392b497e3040c9463a421 
  config/behavior-config.cpp 357ede0eff85c8ac149d07c54f69c941e7e2179c 
  config/behavior-config.ui f78393112172eda1ae8e3a768f4087bc97672cf3 
  lib/channel-contact-model.cpp 109e6b14769e362c1e9ac7af60ba49c15bb1ff47 
  lib/chat-widget.cpp a08f5e87978e121e2541480f3e9b5fdb5e5b753d 
  lib/text-chat-config.h 95c14e133cd8d7f2235010a6e5ba77f2c86996de 
  lib/text-chat-config.cpp bbcedcf85d2c435fcd82914b96ce36be22646444 

Diff: http://git.reviewboard.kde.org/r/110009/diff/


Testing
-------

Chatted with myself (on another system). First with the option checked and then unchecked.

For the "show me typing" setting was sending something to the other side and observed that when checked I got information (on the other system) that the contact was typing and when unchecked did not.

For the "show others typing" setting was typing from the other system and observed that when checked I got informed about the activity and then unchecked did not.


File Attachments
----------------

with new options
  http://git.reviewboard.kde.org/media/uploaded/files/2013/04/14/new_config.png
without new options
  http://git.reviewboard.kde.org/media/uploaded/files/2013/04/14/without_new_config.png


Thanks,

Stefan Eggers

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130416/8f7b75a1/attachment.html>