Review Request 110034: Added preview for YouTube short links (youtu.be) in text-ui

Anant Kamath kamathanant at gmail.com
Tue Apr 16 01:37:47 UTC 2013



> On April 16, 2013, 1:23 a.m., David Edmundson wrote:
> > filters/youtube/youtube-filter.cpp, line 67
> > <http://git.reviewboard.kde.org/r/110034/diff/1/?file=139004#file139004line67>
> >
> >     QLatin1Char('/')
> >     
> >     (note the quotes change too)

fixed in the revised diff. Will push this one.


- Anant


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110034/#review31131
-----------------------------------------------------------


On April 16, 2013, 1:36 a.m., Anant Kamath wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110034/
> -----------------------------------------------------------
> 
> (Updated April 16, 2013, 1:36 a.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Description
> -------
> 
> The youtube filter has been modified so that youtu.be links are previewed in text-ui now.
> 
> Screenshot : http://tinypic.com/r/2mcbv2p/6
> 
> 
> This addresses bug 318314.
>     http://bugs.kde.org/show_bug.cgi?id=318314
> 
> 
> Diffs
> -----
> 
>   filters/youtube/youtube-filter.cpp 50986a4 
> 
> Diff: http://git.reviewboard.kde.org/r/110034/diff/
> 
> 
> Testing
> -------
> 
> Tested with multiple links
> 
> 
> Thanks,
> 
> Anant Kamath
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130416/578b2bca/attachment.html>


More information about the KDE-Telepathy mailing list