Review Request 110034: Added preview for YouTube short links (youtu.be) in text-ui

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110034/#review31131
-----------------------------------------------------------

Ship it!


Do you have commit access? 
Or shall we commit on your behalf?


filters/youtube/youtube-filter.cpp
<http://git.reviewboard.kde.org/r/110034/#comment23144>

    QLatin1Char('/')
    
    (note the quotes change too)



filters/youtube/youtube-filter.cpp
<http://git.reviewboard.kde.org/r/110034/#comment23143>

    Set your text editor up to remove whitespaces on saving.
    
    It sounds pedantic, but it means the next time someone else edits the file it will show them having changed this line even though they didn't, and it complicates our diffs.


- David Edmundson


On April 16, 2013, 1:20 a.m., Anant Kamath wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110034/
> -----------------------------------------------------------
> 
> (Updated April 16, 2013, 1:20 a.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Description
> -------
> 
> The youtube filter has been modified so that youtu.be links are previewed in text-ui now.
> 
> Screenshot : http://tinypic.com/r/2mcbv2p/6
> 
> 
> This addresses bug 318314.
>     http://bugs.kde.org/show_bug.cgi?id=318314
> 
> 
> Diffs
> -----
> 
>   filters/youtube/youtube-filter.cpp 50986a4 
> 
> Diff: http://git.reviewboard.kde.org/r/110034/diff/
> 
> 
> Testing
> -------
> 
> Tested with multiple links
> 
> 
> Thanks,
> 
> Anant Kamath
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130416/da20d0a2/attachment-0001.html>