Review Request 110009: add option to show me typing (to others) and others typing (to me)

[Stefan Eggers]

> On April 14, 2013, 1:46 p.m., David Edmundson wrote:
> > File Attachment: with new options
> > <http://git.reviewboard.kde.org/r/110009/#fcomment46>
> >
> >     Why would one want to use this?
> 
> David Edmundson wrote:
>     To clarify (because my screenshot comment doesn't show properly) I mean in particular the option to disable seeing when other people are typing.
> 
> Thomas Pfeiffer wrote:
>     I can see a point in that. Those this is not a privacy concern, I can imagine people who don't care whether someone is typing and simply find the change in window title and the line in the chat window annoying/distracting.
> 
> Stefan Eggers wrote:
>     When I use Skype for a chat I sometimes wait when I know the other side is typing something. Instead of waiting for them to finish (which could take a long time) I could just do something else meanwhile. Thus I turned it off in my Skype client to not get distracted this way.
> 
> David Edmundson wrote:
>     I still don't understand, you can still (in your example) just close Skype.
>     
>     Code is fine (really good in fact). I want an opinion from someone else before I click ship it.

To make it a bit clearer what the intended result is so it's easier to decide if this makes sense:

1) As Thomas pointed out the notification about composing a reply might be annoying and/or distracting people. Other notifications one can turn off completely, but w/o this change you can't turn off these when the other side composes a reply:

- Changing window title.
- Changing icon in the window frame.
- Changing icon in the window panel (my German system names it "Fensterleiste"; hope translated it right).
- Changing icon on the tab and changing tab name color if you happen to use multiple tabs in ktp-text-ui.

So three to four places something visually changes and no way to turn it off.

2) Closing the window will require me to reopen the window when the reply arrives. That might be in a few minutes and in that case closing the window is OK to me or it might be in a few seconds and for this case I leave the chat window open. Problem is: If I leave it open and get a notification that the other side is writing something I am tempted to just wait and see instead of first doing something else (e.g. as small as starting a build of KTP).


- Stefan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110009/#review31018
-----------------------------------------------------------


On April 14, 2013, 1:44 p.m., Stefan Eggers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110009/
> -----------------------------------------------------------
> 
> (Updated April 14, 2013, 1:44 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> add option to show me typing (to others) and others typing (to me)
> 
> Adding two configuration options which allow to select if:
> 
> - Others get shown that I am typing.
> - I get shown that others are typing.
> 
> This add the options wished for in bug 282201.
> 
> 
> This addresses bug 282201.
>     http://bugs.kde.org/show_bug.cgi?id=282201
> 
> 
> Diffs
> -----
> 
>   app/chat-window.cpp 17300d81f2fff8d2604a1d493fbc8b30cf9e169c 
>   config/behavior-config.h fa0f68615f8bb85c108392b497e3040c9463a421 
>   config/behavior-config.cpp 357ede0eff85c8ac149d07c54f69c941e7e2179c 
>   config/behavior-config.ui f78393112172eda1ae8e3a768f4087bc97672cf3 
>   lib/channel-contact-model.cpp 109e6b14769e362c1e9ac7af60ba49c15bb1ff47 
>   lib/chat-widget.cpp a08f5e87978e121e2541480f3e9b5fdb5e5b753d 
>   lib/text-chat-config.h 95c14e133cd8d7f2235010a6e5ba77f2c86996de 
>   lib/text-chat-config.cpp bbcedcf85d2c435fcd82914b96ce36be22646444 
> 
> Diff: http://git.reviewboard.kde.org/r/110009/diff/
> 
> 
> Testing
> -------
> 
> Chatted with myself (on another system). First with the option checked and then unchecked.
> 
> For the "show me typing" setting was sending something to the other side and observed that when checked I got information (on the other system) that the contact was typing and when unchecked did not.
> 
> For the "show others typing" setting was typing from the other system and observed that when checked I got informed about the activity and then unchecked did not.
> 
> 
> File Attachments
> ----------------
> 
> with new options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/14/new_config.png
> without new options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/14/without_new_config.png
> 
> 
> Thanks,
> 
> Stefan Eggers
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130415/e1996f4c/attachment.html>