Review Request 110020: Create a class that manages all Tp::AccountManager

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110020/#review31037
-----------------------------------------------------------



KTp/Declarative/telepathy-manager.h
<http://git.reviewboard.kde.org/r/110020/#comment23086>

    Add me here too



KTp/Declarative/telepathy-manager.h
<http://git.reviewboard.kde.org/r/110020/#comment23087>

    Update.



KTp/Declarative/telepathy-manager.cpp
<http://git.reviewboard.kde.org/r/110020/#comment23088>

    Move the added features here. They shouldn't be in this ctor. That's the point.



KTp/Models/contacts-filter-model.cpp
<http://git.reviewboard.kde.org/r/110020/#comment23089>

    This was a bodge to work round a bug in ContactsModel that I now hit.
    
    We need to export the roleNames in ContactsModel ourselves rather than rely on the source model doing it.. as we haven't set that yet.


- David Edmundson


On April 15, 2013, 12:45 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110020/
> -----------------------------------------------------------
> 
> (Updated April 15, 2013, 12:45 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Create a class that manages all Tp::AccountManager
> 
> This also handles Tp Actions and Tp::ClientRegistrar so we don't 
> This simplifies all our declarative code a lot.
> 
> This also allows KTp plasmoids to declare their own client name rather than hardcoding it into the engine (which was wrong)
> 
> Basically this fixes _Everything_ in one go.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/CMakeLists.txt 32ec1c668afface2f60fd4e884c3987e069d831d 
>   KTp/Declarative/contact-list.h ff8fc1bffd0f87298033875233cf5e1d370f6a4f 
>   KTp/Declarative/contact-list.cpp d469f2c02dfbaac0b5834e57f4347f8d0219d29d 
>   KTp/Declarative/conversations-model.h 370825098de456ee70b37d426f2d743209ef5768 
>   KTp/Declarative/declarative-ktp-actions.h 186d421351fee45d4ef592d50408a20c8d23655c 
>   KTp/Declarative/declarative-ktp-actions.cpp 46d9c2493040fd0bdedf17ab74a9e1d09a17522c 
>   KTp/Declarative/qml-plugins.h 5efc4fdaf5fb24b4a547df8c31a16f263049029a 
>   KTp/Declarative/qml-plugins.cpp ec7c8afe0824ca61e94c8d544a1c5b9badfc3366 
>   KTp/Declarative/telepathy-manager.h PRE-CREATION 
>   KTp/Declarative/telepathy-manager.cpp PRE-CREATION 
>   KTp/Declarative/telepathy-text-observer.h 3fa20f88f81e6e3f8b23ca123ba612db83e240c7 
>   KTp/Declarative/telepathy-text-observer.cpp a44e5a15ed44a9ff336884b671e8e9cc59531360 
>   KTp/Models/contacts-filter-model.cpp 49166aa27a8594ef00ee10cbd62b31f8fce6386f 
>   KTp/Models/contacts-model.h 41c1cb33c73f51f4585a8c36934ae0c96d98e99e 
>   tests/CMakeLists.txt bbd06e7930d995a17e294f831a7fead293ed87f5 
>   tests/pinned-contacts-model-view-main.cpp e94de014bcd944d95ff63aadee537e6932412733 
> 
> Diff: http://git.reviewboard.kde.org/r/110020/diff/
> 
> 
> Testing
> -------
> 
> Updated KTp active to use this:
> 
> Relevant code in main:
> 
> 
>     Component.onCompleted: {
>         telepathyManager.addAllFeatures();
>         telepathyManager.becomeReady();
>     }
> 
> 
> Contact list can create a model directly:
>                     model: KTp.ContactsModel {
>                         id: contactList
>                         accountManager: telepathyManager.accountManager;
>                         presenceTypeFilterFlags: KTp.ContactsModel.HideAllOffline;
>                         sortRoleString: sortRoleString = "presenceType";
>                     }
> 
> 
> without any component.onCompleted anywhere.
> 
> ChatView is now just:
> 
>         Repeater {
>             model: KTp.ConversationsModel {
>                 id: conversationsModel
>             }
> 
>             delegate: Chat {
>                 anchors.fill: parent
>             }
>         }
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130415/e51e83fa/attachment-0001.html>