Review Request 109834: Expose senderAvatar in KTp::Message

David Edmundson david at davidedmundson.co.uk
Sun Apr 14 19:01:11 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109834/
-----------------------------------------------------------

(Updated April 14, 2013, 7:01 p.m.)


Review request for Telepathy.


Description
-------

Expose senderAvatar in KTp::Message

Simplify code and make it less possible to crash.
Store the contactPtr of the sender where possible to avoid storing the samepixmap many times.

Use avatarData so we have pixmaps for offline users


Diffs (updated)
-----

  KTp/message.h 812c90e6ddf6d77af9ffab1f866be57fe95419aa 
  KTp/message.cpp cbb91346bc174ebbab279b2eae732a1e322b5a7e 

Diff: http://git.reviewboard.kde.org/r/109834/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130414/52ac60fb/attachment.html>


More information about the KDE-Telepathy mailing list