Review Request 109979: Check account as well as target ID when searching for existing channels

Dan Vrátil dvratil at redhat.com
Fri Apr 12 17:25:57 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109979/#review30963
-----------------------------------------------------------

Ship it!


Looks good to me.

- Dan Vrátil


On April 12, 2013, 6:34 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109979/
> -----------------------------------------------------------
> 
> (Updated April 12, 2013, 6:34 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Check account as well as target ID when searching for existing channels
> 
> BUG: 317909
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h f7c51b37b2a007178a7a3c9750553eaddc9d6040 
>   app/chat-window.cpp 17300d81f2fff8d2604a1d493fbc8b30cf9e169c 
>   app/telepathy-chat-ui.cpp b604f1c6857378f686fa2d3559aa6ced45ad1351 
> 
> Diff: http://git.reviewboard.kde.org/r/109979/diff/
> 
> 
> Testing
> -------
> 
> Started a chat with person A and person B, clicked on person A in the contact list, that still worked.
> 
> So I've tested I haven't broken anything, I can't easily test the case the user in the bug had.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130412/3d47778d/attachment.html>


More information about the KDE-Telepathy mailing list