Review Request 109948: KTp Chat plasmoid: Improve reaction to closing dialog

Aleix Pol Gonzalez aleixpol at gmail.com
Wed Apr 10 16:34:18 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109948/
-----------------------------------------------------------

(Updated April 10, 2013, 4:34 p.m.)


Status
------

This change has been discarded.


Review request for Telepathy and David Edmundson.


Description
-------

Delegate deletion happens after deletion of the data, so we don't have the index available anymore. This makes it so when we close the dialog the UI doesn't react appropriately.

This patch copies our code to react to the delegate deletion (hidding the dialog) before the actual deletion happens.


Diffs
-----

  chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml 10e7d43 

Diff: http://git.reviewboard.kde.org/r/109948/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130410/be61ba6e/attachment.html>


More information about the KDE-Telepathy mailing list