Review Request 109948: KTp Chat plasmoid: Improve reaction to closing dialog

[Aleix Pol Gonzalez]

> On April 10, 2013, 4:09 p.m., David Edmundson wrote:
> > chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml, line 132
> > <http://git.reviewboard.kde.org/r/109948/diff/1/?file=138134#file138134line132>
> >
> >     I don't understand the patch. 
> >     
> >     As I understand it requestClose() invalidates the channel. When the channel is invalided the ConversationsModel removes it.
> >     
> >     When the model removes it the delegate should be deleted. Right?
> >

Well, yes, but we still need to tell the main plasmoid component that the current view was hidden. That's why I say that we need to know the index when we're closing, otherwise we try to do that onVisibleChanged with visible is false, but then the index is not valid anymore and we cannot tell that it is the current view.


On April 10, 2013, 4:09 p.m., Aleix Pol Gonzalez wrote:
> > In addition closeRequested and requestClose() doing completely different things is very confusing.

Regarding the naming, yes it's pretty bad. I can change it too.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109948/#review30849
-----------------------------------------------------------


On April 10, 2013, 3:50 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109948/
> -----------------------------------------------------------
> 
> (Updated April 10, 2013, 3:50 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Delegate deletion happens after deletion of the data, so we don't have the index available anymore. This makes it so when we close the dialog the UI doesn't react appropriately.
> 
> This patch copies our code to react to the delegate deletion (hidding the dialog) before the actual deletion happens.
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml 10e7d43 
> 
> Diff: http://git.reviewboard.kde.org/r/109948/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130410/ebea501e/attachment.html>