Review Request 109925: Make sure ConversationModel never close a channels it is not handling

Aleix Pol Gonzalez aleixpol at gmail.com
Tue Apr 9 21:51:48 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109925/#review30819
-----------------------------------------------------------


Looks good to me, but i have little idea about what it does :)

- Aleix Pol Gonzalez


On April 9, 2013, 12:48 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109925/
> -----------------------------------------------------------
> 
> (Updated April 9, 2013, 12:48 p.m.)
> 
> 
> Review request for Telepathy and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> Make sure ConversationModel never close a channel it is not handling
> 
> BUG: 293637
> BUG: 317850
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/conversation.cpp 3975e001f786be50df8958b5dd0162b650c9a220 
>   KTp/Declarative/conversations-model.cpp c713ce7aeb909211a56b9a73bf70e5a9844f4124 
> 
> Diff: http://git.reviewboard.kde.org/r/109925/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130409/397a7643/attachment.html>


More information about the KDE-Telepathy mailing list