Review Request 109852: Restore printing tp-qt version and fix it for debug kdelibs

[David Edmundson]

> On April 4, 2013, 11:20 a.m., David Edmundson wrote:
> > What Alex is trying to say is "Ship it!"
> > 
> > Do we want to backport it? I'm more skeptical about doing that till have a bit more testing.
> 
> Aleix Pol Gonzalez wrote:
>     Well, the current implementation has crashes, I'm skeptical about keeping that :P.
> 
> David Edmundson wrote:
>     No it doesn't.
>     
>     It used to crash. Then I removed the code before 0.6. This patch restores it in a less crashy way.
> 
> Daniele E. Domenichelli wrote:
>     So I'd say either apply the patch in 0.6 or remove the extra string and the extra check in 0.6 and apply to master. Not a very big deal but it does help a lot in spotting telepathy-qt warnings

Ship it but lets not rush a 0.6.1.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109852/#review30357
-----------------------------------------------------------


On April 4, 2013, 9:14 a.m., Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109852/
> -----------------------------------------------------------
> 
> (Updated April 4, 2013, 9:14 a.m.)
> 
> 
> Review request for Telepathy, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Description
> -------
> 
> Restore printing tp-qt version and fix it for debug kdelibs
> 
> Commit 6cbefb04441bab0d25dde78d95a2adee4d163fd5 "Prevent crashes with
> debug kdelibs" should probably have been reverting commit
> 58d7eb5a461bc597455065da3a4cd813e4f0a15a "Print tp-qt library name and
> version in tp-qt debug"
> 
> If the line cannot be printed, it doesn't make sense to keep the extra
> string and the extra check.
> 
> Anyway the problem seem to come with a Q_ASSERT_X in kdelibs that
> searches for "(" (see kdelibs kdecore/io/kdebug.cpp.html:577)
> 
> This patch restore the previous behaviour, and should fix the crash.
> 
> Also add a ":" to the string, because I realized that everything that
> comes before the white space is stripped away, so now it prints
> something like "tp-qt:0.9.3.1"
> 
> 
> Diffs
> -----
> 
>   KTp/debug.cpp adad3fbad2456379d0f0775fc701904316479f68 
> 
> Diff: http://git.reviewboard.kde.org/r/109852/diff/
> 
> 
> Testing
> -------
> 
> I don't have kdelibs built with debug, so please test it if you have.
> 
> 
> Thanks,
> 
> Daniele E. Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130404/c9a0c3bf/attachment.html>