Review Request 109852: Restore printing tp-qt version and fix it for debug kdelibs
Daniele E. Domenichelli
daniele.domenichelli at gmail.com
Thu Apr 4 09:14:31 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109852/
-----------------------------------------------------------
Review request for Telepathy, Aleix Pol Gonzalez and David Edmundson.
Description
-------
Restore printing tp-qt version and fix it for debug kdelibs
Commit 6cbefb04441bab0d25dde78d95a2adee4d163fd5 "Prevent crashes with
debug kdelibs" should probably have been reverting commit
58d7eb5a461bc597455065da3a4cd813e4f0a15a "Print tp-qt library name and
version in tp-qt debug"
If the line cannot be printed, it doesn't make sense to keep the extra
string and the extra check.
Anyway the problem seem to come with a Q_ASSERT_X in kdelibs that
searches for "(" (see kdelibs kdecore/io/kdebug.cpp.html:577)
This patch restore the previous behaviour, and should fix the crash.
Also add a ":" to the string, because I realized that everything that
comes before the white space is stripped away, so now it prints
something like "tp-qt:0.9.3.1"
Diffs
-----
KTp/debug.cpp adad3fbad2456379d0f0775fc701904316479f68
Diff: http://git.reviewboard.kde.org/r/109852/diff/
Testing
-------
I don't have kdelibs built with debug, so please test it if you have.
Thanks,
Daniele E. Domenichelli
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130404/f97e4c4c/attachment.html>
More information about the KDE-Telepathy
mailing list