Review Request 109835: Move AdiumContentInfo to be internal to AdiumThemeView

[David Edmundson]

> On April 3, 2013, 4:49 p.m., Dan Vrátil wrote:
> > lib/adium-theme-view.cpp, line 368
> > <http://git.reviewboard.kde.org/r/109835/diff/1/?file=128988#file128988line368>
> >
> >     I know you added KTp::Message::senderAvatar(), but I haven't found senderAvatarPath()

That was well noticed :)
I was making this patch when I realised what I did in the lib won't work.


> On April 3, 2013, 4:49 p.m., Dan Vrátil wrote:
> > lib/logmanager.cpp, line 164
> > <http://git.reviewboard.kde.org/r/109835/diff/1/?file=128992#file128992line164>
> >
> >     You can probably remove all the commented code

Yeah, not sure why I didn't do that.
Thanks.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109835/#review30324
-----------------------------------------------------------


On April 3, 2013, 12:14 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109835/
> -----------------------------------------------------------
> 
> (Updated April 3, 2013, 12:14 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Move AdiumContentInfo to be internal to AdiumThemeView
> 
> AdiumThemeView now takes a KTp::Message which contains all the information needed to present information in the view.
> /me messages are passed as KTp::Messages, in future status messages will be too.
> 
> I also had to fix entity model to take KTp::ContactPtr because of a conflict in Qt MetaTypes after including KTp code. 
> 
> 
> Diffs
> -----
> 
>   config/appearance-config-tab.cpp fadfd474a9b702c5e24046790eb19ceb0e34a8b5 
>   lib/adium-theme-view.h 70618f66ff374c9775391eb0890beb6fddcffd5c 
>   lib/adium-theme-view.cpp 361cd6da826f6d684ddd1a145a6c719848745134 
>   lib/chat-widget.h 95b86f8c52429c4cd759fb46538a67d40161f6de 
>   lib/chat-widget.cpp 5787940f071d46fa209de5650de20a42a305bd4e 
>   lib/logmanager.h 9b1d010717a153206fabf448dd1502d3d61a7917 
>   lib/logmanager.cpp a570adfaaf7b1b03aab246ddbf1ba4cd5ae22733 
>   logviewer/entity-model-item.h 47d98cdb7ac90efc54ca9ee1df880b8e7b6f9843 
>   logviewer/entity-model-item.cpp a08ccc221e89510ca2057b63d0fffdc7ca459ce2 
>   logviewer/entity-model.h 5c9aa73d621c8d21601fab892890f5ae7c60e28c 
>   logviewer/entity-model.cpp 1c10c1d758a4eb0f7792fa1660effefccecc24f2 
>   logviewer/entity-proxy-model.cpp 67811f61c1c5a2d2fa35534af1228f7b726e8706 
>   logviewer/log-viewer.cpp 5c2e2140b03da68d64177b0ef1ea994b95e6e94c 
>   logviewer/main.cpp 48d5ee2813241e6659eb032a517994dcb4220b63 
>   logviewer/message-view.cpp 6a59caa0b40b528fc69497e8ba4d42f683a74e65 
> 
> Diff: http://git.reviewboard.kde.org/r/109835/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130403/e6e4bd84/attachment.html>