Review Request: Make AccountsModelItem private and instead expose a role of just the AccountPtr

David Edmundson kde at davidedmundson.co.uk
Sun Sep 30 23:53:09 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106664/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Make AccountsModelItem private and instead expose a role of just the AccountPtr

This means AccountsItem can be private, ready for the move to extragear.
Also fixes a potential crash if the account is removed whilst editing as EditAccountDialog stores the AccountPtr which is ref counted.


Diffs
-----

  src/account-item.h a2fee834c7e0e65931fa82c437be754e95ec333c 
  src/account-item.cpp 8efc78fb135b7cf29b750fcfeb11c1b94eaa44a6 
  src/accounts-list-delegate.cpp a2333290639588b6d6c09e3ae149083001da45d2 
  src/accounts-list-model.h 10786674ab0d5a7bada9f6b3e3be9acd0aa235cd 
  src/accounts-list-model.cpp 4a015fa517c625099f4fb05da3572e53b243d2ad 
  src/edit-account-dialog.h 08a3481b6d0566f0314d1682ef722e38862fe105 
  src/edit-account-dialog.cpp a747242a0eba49791d60a2f986228133297012a1 
  src/kcm-telepathy-accounts.cpp 8d1f2ece4943feec257eb761cf5a803a004b60cb 

Diff: http://git.reviewboard.kde.org/r/106664/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120930/040d440e/attachment.html>


More information about the KDE-Telepathy mailing list