Review Request: Fix opening logviewer with preselected Facebook contact

[Dan Vratil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106635/
-----------------------------------------------------------

(Updated Sept. 30, 2012, 5:36 p.m.)


Review request for Telepathy.


Changes
-------

As George pointed out in the bug, using

ktp-log-viewer -- accountID contactID

works. So I dropped the change in logviewer cmd line syntax and only added "--" to arguments when invoking logviewer from text-ui


Description
-------

Starting logviewer with preselected Facebook contact fails, because Facebook contacts UIDs start with "-", so KCmdLineArgs interprets it as an (invalid) argument and fails to start logviewer.

This patch changes logviewer cmd line syntax to

ktp-log-viewer accountID,contactID

i.e. passing accountID and contactID as a single argument and separating them just by comma. This assumes comma is not an allowed character within accountID and contactID, which I believe is a safe assumption.


This addresses bug 307577.
    http://bugs.kde.org/show_bug.cgi?id=307577


Diffs (updated)
-----

  app/chat-window.cpp 57cc33f 

Diff: http://git.reviewboard.kde.org/r/106635/diff/


Testing
-------


Thanks,

Dan Vratil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120930/444d5630/attachment.html>