Review Request: Add context menu entry to modify contact notifications
Commit Hook
null at kde.org
Sat Sep 29 14:19:04 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106353/#review19588
-----------------------------------------------------------
This review has been submitted with commit a5591bbc20dfecbe907bdc5fb5bebb5f9ce11c0c by Rohan Garg to branch master.
- Commit Hook
On Sept. 28, 2012, 9:29 p.m., Rohan Garg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106353/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2012, 9:29 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Add context menu entry to modify contact notifications
>
> The position of the configure entry is debatable, should it be at the bottom with "Show info" ? I'd like to hear your opinions :)
>
>
> Diffs
> -----
>
> CMakeLists.txt 7cb36cf9b065d572799308fdc52b746f3388f527
> context-menu.h 5a30c6d326c7401d7f226fdca1cb90b65d650403
> context-menu.cpp 10f3d90cc7de3c7ce5072d3a6dc449f9ecb8e721
>
> Diff: http://git.reviewboard.kde.org/r/106353/diff/
>
>
> Testing
> -------
>
> Right click a contact > click "Configure Notifications" > Brings up notification configuration dialog
>
>
> Screenshots
> -----------
>
>
> http://git.reviewboard.kde.org/r/106353/s/716/
>
>
> Thanks,
>
> Rohan Garg
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120929/338ca606/attachment.html>
More information about the KDE-Telepathy
mailing list