Review Request: Implement contact notifications

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106355/#review19546
-----------------------------------------------------------

Ship it!



contactnotify.h
<http://git.reviewboard.kde.org/r/106355/#comment15520>

    Coding style - put forward declarations below #include



contactnotify.h
<http://git.reviewboard.kde.org/r/106355/#comment15521>

    Coding style - put forward declarations under #include



contactnotify.h
<http://git.reviewboard.kde.org/r/106355/#comment15522>

    const Tp::ContactPtr &



contactnotify.h
<http://git.reviewboard.kde.org/r/106355/#comment15523>

    const &



contactnotify.cpp
<http://git.reviewboard.kde.org/r/106355/#comment15524>

    the slot would be better named as "onContactsChanged(..)"



contactnotify.cpp
<http://git.reviewboard.kde.org/r/106355/#comment15525>

    const &



contactnotify.cpp
<http://git.reviewboard.kde.org/r/106355/#comment15526>

    it's not a "presence message", but a "presence name"



contactnotify.cpp
<http://git.reviewboard.kde.org/r/106355/#comment15528>

    You might want to disconnect for those contacts here...but probably not an issue


- Martin Klapetek


On Sept. 28, 2012, 9:25 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106355/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2012, 9:25 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Minor styling fixup
> 
> 
> Make sure that the connection and contacts actually exist before doing anything
> 
> This change makes the code a bit more asynchronous and uses the right
> eventID for notifications
> 
> Implement contact notifications
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 96cedcff5a09eb26217b9032a68f4b4e01768805 
>   contactnotify.h PRE-CREATION 
>   contactnotify.cpp PRE-CREATION 
>   telepathy-module.h 15666bcebf6d4b1d9640e016ff8d6202471b7629 
>   telepathy-module.cpp 2085fea3d133db388e43c47ee8b0f3af8d5279cd 
> 
> Diff: http://git.reviewboard.kde.org/r/106355/diff/
> 
> 
> Testing
> -------
> 
> Notifications from specific contacts were shown.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/106355/s/718/
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120928/4598a5d1/attachment-0001.html>