Review Request: Add the contactInfo event for contact notifications

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106354/#review19545
-----------------------------------------------------------



KTp/Widgets/notificationconfigdialog.cpp
<http://git.reviewboard.kde.org/r/106354/#comment15518>

    I don't understand what this is doing.
    
    you shouldn't need to subclass show in a dialog. And you shouldn't be manually showing child items from a dialog.



KTp/Widgets/notificationconfigdialog.cpp
<http://git.reviewboard.kde.org/r/106354/#comment15519>

    this is already a slot, why make a slot to put the slot in?


- David Edmundson


On Sept. 28, 2012, 9:43 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106354/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2012, 9:43 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add the contactInfo event for contact notifications
> 
> 
> Diffs
> -----
> 
>   KTp/Widgets/CMakeLists.txt 0dcf7c13ef7013afb94e3685f1925d59bece1833 
>   KTp/Widgets/notificationconfigdialog.h PRE-CREATION 
>   KTp/Widgets/notificationconfigdialog.cpp PRE-CREATION 
>   data/ktelepathy.notifyrc 00e1508ff87a1a0f3a8252adbc66633e2c6c9487 
> 
> Diff: http://git.reviewboard.kde.org/r/106354/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120928/8f37c902/attachment.html>