Review Request: Implement contact notifications
Rohan Garg
rohangarg at kubuntu.org
Fri Sep 28 21:25:00 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106355/
-----------------------------------------------------------
(Updated Sept. 28, 2012, 9:25 p.m.)
Review request for Telepathy.
Changes
-------
Update to use the new GlobalContactManager class from KTp Common Internals
Description
-------
Minor styling fixup
Make sure that the connection and contacts actually exist before doing anything
This change makes the code a bit more asynchronous and uses the right
eventID for notifications
Implement contact notifications
Diffs (updated)
-----
CMakeLists.txt 96cedcff5a09eb26217b9032a68f4b4e01768805
contactnotify.h PRE-CREATION
contactnotify.cpp PRE-CREATION
telepathy-module.h 15666bcebf6d4b1d9640e016ff8d6202471b7629
telepathy-module.cpp 2085fea3d133db388e43c47ee8b0f3af8d5279cd
Diff: http://git.reviewboard.kde.org/r/106355/diff/
Testing
-------
Notifications from specific contacts were shown.
Screenshots
-----------
http://git.reviewboard.kde.org/r/106355/s/718/
Thanks,
Rohan Garg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120928/b89a0e9c/attachment.html>
More information about the KDE-Telepathy
mailing list