Review Request: Add a class providing a GlobalContact list throughout all accounts

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106404/
-----------------------------------------------------------

(Updated Sept. 28, 2012, 7:58 p.m.)


Review request for Telepathy.


Changes
-------

Change constructor, remove whitespace.

Not addressed Q_PRIVATE_NONSENSE. 
None of the other KTp classes use it. 

I've also not moved AccountContact, I want to see from using it, if we want to add anything to it.


Description
-------

Add a class providing a GlobalContact list throughout all accounts.

So far 3 people have managed to get this wrong when implementing this, including Rohan, Me, George G and Dario so it would be good to have one class that does it right, also I don't like duplicate code.

This is to fix Rohan's patch in the KDED module for monitoring account presences as well as removing all the duplciate code that will be in contact-request-handler. This code will also be useful for the nepomuk-service which also has an implementation of this.

This will also fix the contact-request-handler not being able to display which account a new contact request comes from.


Diffs (updated)
-----

  KTp/CMakeLists.txt fa0c741564e09c020fbe3d3e8b3d375fe9c4c3df 
  KTp/global-contact-manager.h PRE-CREATION 
  KTp/global-contact-manager.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/106404/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120928/d35d9708/attachment.html>