Review Request: Fix on Bug 291764 - Set spellchecking language per contact instead of per tab

[Nick Lou]

> On Sept. 26, 2012, 7:42 a.m., Daniele Elmo Domenichelli wrote:
> > ../../defaults/chat-widget.cpp, lines 1058-1059
> > <http://git.reviewboard.kde.org/r/106575/diff/3/?file=87160#file87160line1058>
> >
> >     } else {

I will fix those things and reupload the diff file!

Just a small thing I noticed (irrelevant to this patch): the file chat-window.cpp has some small mistakes according to Kdelibs coding style:
ChatTab* xVar should be written ChatTab *xVar, where xVar any variable set.Same thing happens with refferences too.


- Nick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106575/#review19439
-----------------------------------------------------------


On Sept. 26, 2012, 2:06 p.m., Nick Lou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106575/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2012, 2:06 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fix for the reported Bug 291764 (Set spellchecking language per contact instead of per tab).
> If a contact changes the default spellchecking option to one of his/her choice, 
> the new option is saved in a file as a pair, target Id and spell checking option, 
> where the target Id is a group and option value has a key named "language".
> 
> 
> This addresses bug 291764.
>     http://bugs.kde.org/show_bug.cgi?id=291764
> 
> 
> Diffs
> -----
> 
>   ../../defaults/chat-widget.h 7d2dcf2 
>   ../../defaults/chat-widget.cpp 6c9c7ed 
>   ../../defaults/chat-window.cpp eb1b7a0 
> 
> Diff: http://git.reviewboard.kde.org/r/106575/diff/
> 
> 
> Testing
> -------
> 
> Tested it by changing the spellchecking option of various pairs,
> and then by closing and reopening their chat tabs and checking the values.
> I also checked the values stored in the config file.
> 
> 
> Thanks,
> 
> Nick Lou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120926/59b950ff/attachment-0001.html>