Review Request: Fix on Bug 291764 - Set spellchecking language per contact instead of per tab
Nick Lou
nicklkde at ymail.com
Tue Sep 25 23:25:17 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106575/
-----------------------------------------------------------
(Updated Sept. 25, 2012, 11:25 p.m.)
Review request for Telepathy.
Changes
-------
Fixed the bugs reported by David Edmundson.
Description
-------
Fix for the reported Bug 291764 (Set spellchecking language per contact instead of per tab).
If a contact changes the default spellchecking option to one of his/her choice,
the new option is saved in a file as a pair, target Id and spell checking option,
where the target Id is a group and option value has a key named "language".
This addresses bug 291764.
http://bugs.kde.org/show_bug.cgi?id=291764
Diffs (updated)
-----
../../defaults/chat-widget.h 7d2dcf2
../../defaults/chat-widget.cpp 6c9c7ed
../../defaults/chat-window.cpp eb1b7a0
Diff: http://git.reviewboard.kde.org/r/106575/diff/
Testing
-------
Tested it by changing the spellchecking option of various pairs,
and then by closing and reopening their chat tabs and checking the values.
I also checked the values stored in the config file.
Thanks,
Nick Lou
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120925/61508218/attachment.html>
More information about the KDE-Telepathy
mailing list