Review Request: Fix a bug in which the PendingWallet would hang forever if the wallet system is disabled

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106560/#review19403
-----------------------------------------------------------

Ship it!


Ship It!

- Daniele Elmo Domenichelli


On Sept. 24, 2012, 10:40 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106560/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2012, 10:40 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fix a bug in which the PendingWallet would hang forever if the wallet system is disabled
> 
> This fixes bugs in the auth handler and AccountsKCM
> 
> BUG: 307237 (auth handler blocks and does nothing)
> BUG: 307302 (accounts KCM crashes)
> BUG: 306953 (accounts KCM crashes)
> 
> 
> Diffs
> -----
> 
>   KTp/pending-wallet.cpp c8680b97be5a40abf4fc310b614c772804a66c39 
> 
> Diff: http://git.reviewboard.kde.org/r/106560/diff/
> 
> 
> Testing
> -------
> 
> Disabled wallet system (before applying patch). Confirmed no widgets appeared
> Applied this patch, everything now works (except password not being saved) 
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120925/39265df4/attachment.html>