Review Request: Check connection manager supports protocol listed in profile

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106515/#review19234
-----------------------------------------------------------

Ship it!


The code is good, however - will this affect these two bugs? https://bugs.kde.org/show_bug.cgi?id=291719 & https://bugs.kde.org/show_bug.cgi?id=304134 - If so, they need fixing too.


src/KCMTelepathyAccounts/profile-list-model.cpp
<http://git.reviewboard.kde.org/r/106515/#comment15256>

    In QtCreator, go Tools -> Options -> Text Editor tab -> Behavior tab -> Cleanups Upon Saving :P



src/KCMTelepathyAccounts/profile-list-model.cpp
<http://git.reviewboard.kde.org/r/106515/#comment15257>

    No space -> !m_con



src/KCMTelepathyAccounts/profile-list-model.cpp
<http://git.reviewboard.kde.org/r/106515/#comment15258>

    No space -> !m_con



src/KCMTelepathyAccounts/profile-list-model.cpp
<http://git.reviewboard.kde.org/r/106515/#comment15259>

    No space -> !hasValid...


- Martin Klapetek


On Sept. 20, 2012, 4:38 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106515/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2012, 4:38 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Check connection manager supports protocol listed in profile. This should fix the issue of skype appearing in the list when telpeathy-haze was installed but pidgin-skype was not.
> 
> ConnectionManagers require having becomeReady() called before the list of protocols they support can be used, hence converting from a list of CMs to a hash of CmPtrs
> 
> Relevant IRC conversation about ABI breaking:
> [16:53] <d_ed> gkiagia: how bad is it to break the ABI on a private library with no installed headers that no-one else uses between 0.5.0 and 0.5.1
> [16:53] <d_ed> (the accounts KCM lib)
> [16:53] <gkiagia> not an issue
> 
> 
> Diffs
> -----
> 
>   src/KCMTelepathyAccounts/profile-list-model.cpp 35ced7cb3e4b4959a798ac6a7a7ff7369f10bb6e 
>   src/KCMTelepathyAccounts/profile-list-model.h d133ffcffec376064264c4310e39d6e0f0f836d0 
> 
> Diff: http://git.reviewboard.kde.org/r/106515/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120920/f79c43dc/attachment-0001.html>