Review Request: Implement TTS Filter

David Edmundson david at davidedmundson.co.uk
Wed Sep 12 14:48:30 UTC 2012


Either way I shouldn't be hardcoding a path, and I should be checking for
it making it optional.
Which has now happened.

Dave

On Wed, Sep 12, 2012 at 3:47 PM, Jeremy Whiting <jpwhiting at kde.org> wrote:

> Aleix,
>
> That file should be shipped with kdelibs.  Maybe yours is in
> /usr/local/share or something?
>
> Jeremy
>
> On Wed, Sep 12, 2012 at 4:22 AM, Aleix Pol Gonzalez <aleixpol at gmail.com>wrote:
>
>>    This is an automatically generated e-mail. To reply, visit:
>> http://git.reviewboard.kde.org/r/106428/
>>
>> Looks like from this review, I'm getting this error message now:
>>
>> ninja: ERROR: '/usr/share/dbus-1/interfaces/org.kde.KSpeech.xml', needed by 'filters/texttospeech/kspeechinterface.cpp', missing and no known rule to make it
>>
>> Maybe some conditional compilation is needed?
>>
>>
>> - Aleix
>>
>> On September 11th, 2012, 10:13 p.m., David Edmundson wrote:
>>   Review request for Telepathy.
>> By David Edmundson.
>>
>> *Updated Sept. 11, 2012, 10:13 p.m.*
>> Description
>>
>> Implement skeleton TTS
>>
>>   Diffs
>>
>>    - filters/CMakeLists.txt (ee7c23d612cbc737271798344b1939052e1b7326)
>>    - filters/texttospeech/CMakeLists.txt (PRE-CREATION)
>>    - filters/texttospeech/ktptextui_message_filter_tts.desktop
>>    (PRE-CREATION)
>>    - filters/texttospeech/tts-filter.h (PRE-CREATION)
>>    - filters/texttospeech/tts-filter.cpp (PRE-CREATION)
>>
>> View Diff <http://git.reviewboard.kde.org/r/106428/diff/>
>>
>> _______________________________________________
>> KDE-Telepathy mailing list
>> KDE-Telepathy at kde.org
>> https://mail.kde.org/mailman/listinfo/kde-telepathy
>>
>>
>
> _______________________________________________
> KDE-Telepathy mailing list
> KDE-Telepathy at kde.org
> https://mail.kde.org/mailman/listinfo/kde-telepathy
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120912/508927bb/attachment.html>


More information about the KDE-Telepathy mailing list