Review Request: More message filters.

Tue Sep 11 22:40:07 UTC 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106083/#review18882
-----------------------------------------------------------

Shaping up nicely, here are some comments.

filters/bugzilla/bugzilla-filter.h
<http://git.reviewboard.kde.org/r/106083/#comment14966>

    If you don't use the QVariantList in the code, then remove it, otherwise give the variable a name.

filters/bugzilla/bugzilla-filter.cpp
<http://git.reviewboard.kde.org/r/106083/#comment14967>

    Can we have a bugbot-like trigger for this? Eg. "bug 321023" in a sentence "can you take a look at bug 321234". Might be worth taking look at bugbot code maybe?

filters/bugzilla/bugzilla-filter.cpp
<http://git.reviewboard.kde.org/r/106083/#comment14968>

    Put a more sensible debug output here or remove it altogether, no need for random strings being spewed in the console ;)

filters/bugzilla/ktptextui_message_filter_bugzilla.desktop
<http://git.reviewboard.kde.org/r/106083/#comment14969>

    0.6

filters/bugzilla/ktptextui_message_filter_bugzilla.desktop
<http://git.reviewboard.kde.org/r/106083/#comment14970>

    LGPL

filters/highlight/highlight-filter.h
<http://git.reviewboard.kde.org/r/106083/#comment14971>

    I think the filters can use a short description of what they actually do in a comment

filters/highlight/highlight-filter.h
<http://git.reviewboard.kde.org/r/106083/#comment14972>

    Remove the QVariantList if you're not using it

filters/highlight/ktptextui_message_filter_highlight.desktop
<http://git.reviewboard.kde.org/r/106083/#comment14973>

    0.6, LGPL

filters/latex/CMakeLists.txt
<http://git.reviewboard.kde.org/r/106083/#comment14974>

    You don't need emoticons for latex

filters/latex/ktptextui_message_filter_latex.desktop
<http://git.reviewboard.kde.org/r/106083/#comment14975>

    0.6, LGPL

filters/latex/latex-filter.h
<http://git.reviewboard.kde.org/r/106083/#comment14976>

    Again, the qvariantlist

filters/pipes/CMakeLists.txt
<http://git.reviewboard.kde.org/r/106083/#comment14977>

    You don't need emoticons here either.

filters/pipes/ktptextui_message_filter_pipes.desktop
<http://git.reviewboard.kde.org/r/106083/#comment14978>

    0.6, LGPL

filters/pipes/pipes-config.cpp
<http://git.reviewboard.kde.org/r/106083/#comment14979>

    Coding style says "...args)
        : KCModule(..."

filters/pipes/pipes-config.cpp
<http://git.reviewboard.kde.org/r/106083/#comment14980>

    Might be worth to add context -- i18nc(..)

filters/pipes/pipes-config.cpp
<http://git.reviewboard.kde.org/r/106083/#comment14981>

    Same here

filters/pipes/pipes-config.cpp
<http://git.reviewboard.kde.org/r/106083/#comment14982>

    Braces coding style

filters/pipes/pipes-config.cpp
<http://git.reviewboard.kde.org/r/106083/#comment14983>

    New line at the end of file. Actually of all your files (just noticed the rest)

- Martin Klapetek

On Sept. 11, 2012, 10:19 p.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106083/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2012, 10:19 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Right, so here's a big fat review containing many many things, including all the remaining plugins and a few tweaks to Message.
> 
> As per usual, all the code is in my scratch repo: http://quickgit.kde.org/index.php?p=clones%2Fktp-text-ui%2Ffernando%2Fgsoc.git&a=summary
> 
> Now, I'm going to take a well earned nap.
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt ee7c23d 
>   filters/bugzilla/CMakeLists.txt PRE-CREATION 
>   filters/bugzilla/bugzilla-filter.h PRE-CREATION 
>   filters/bugzilla/bugzilla-filter.cpp PRE-CREATION 
>   filters/bugzilla/ktptextui_message_filter_bugzilla.desktop PRE-CREATION 
>   filters/highlight/CMakeLists.txt PRE-CREATION 
>   filters/highlight/highlight-filter.h PRE-CREATION 
>   filters/highlight/highlight-filter.cpp PRE-CREATION 
>   filters/highlight/ktptextui_message_filter_highlight.desktop PRE-CREATION 
>   filters/latex/CMakeLists.txt PRE-CREATION 
>   filters/latex/ktp_message_filter_latex_converter.sh PRE-CREATION 
>   filters/latex/ktptextui_message_filter_latex.desktop PRE-CREATION 
>   filters/latex/latex-filter.h PRE-CREATION 
>   filters/latex/latex-filter.cpp PRE-CREATION 
>   filters/pipes/CMakeLists.txt PRE-CREATION 
>   filters/pipes/kcm_ktp_filter_config_pipes.desktop PRE-CREATION 
>   filters/pipes/ktptextui_message_filter_pipes.desktop PRE-CREATION 
>   filters/pipes/pipes-config.h PRE-CREATION 
>   filters/pipes/pipes-config.cpp PRE-CREATION 
>   filters/pipes/pipes-config.ui PRE-CREATION 
>   filters/pipes/pipes-delegate.h PRE-CREATION 
>   filters/pipes/pipes-delegate.cpp PRE-CREATION 
>   filters/pipes/pipes-filter.h PRE-CREATION 
>   filters/pipes/pipes-filter.cpp PRE-CREATION 
>   filters/pipes/pipes-model.h PRE-CREATION 
>   filters/pipes/pipes-model.cpp PRE-CREATION 
>   filters/pipes/pipes-prefs.h PRE-CREATION 
>   filters/pipes/pipes-prefs.cpp PRE-CREATION 
>   filters/pipes/pipes-prefstest.h PRE-CREATION 
>   filters/pipes/pipes-prefstest.cpp PRE-CREATION 
>   filters/substitution/CMakeLists.txt PRE-CREATION 
>   filters/substitution/kcm_ktp_filter_config_substitution.desktop PRE-CREATION 
>   filters/substitution/ktptextui_message_filter_substitution.desktop PRE-CREATION 
>   filters/substitution/substitution-config.h PRE-CREATION 
>   filters/substitution/substitution-config.cpp PRE-CREATION 
>   filters/substitution/substitution-config.ui PRE-CREATION 
>   filters/substitution/substitution-filter.h PRE-CREATION 
>   filters/substitution/substitution-filter.cpp PRE-CREATION 
>   filters/substitution/substitution-prefs.h PRE-CREATION 
>   filters/substitution/substitution-prefs.cpp PRE-CREATION 
>   filters/youtube/CMakeLists.txt PRE-CREATION 
>   filters/youtube/ktptextui_message_filter_youtube.desktop PRE-CREATION 
>   filters/youtube/youtube-filter.h PRE-CREATION 
>   filters/youtube/youtube-filter.cpp PRE-CREATION 
>   lib/abstract-message-filter.h 7b60d48 
>   lib/abstract-message-filter.cpp 2a3a897 
>   lib/message.h ef9530b 
>   lib/message.cpp 6db648e 
>   tests/message-processor-basic-tests.h 7dc99e4 
>   tests/message-processor-basic-tests.cpp 8546605 
> 
> Diff: http://git.reviewboard.kde.org/r/106083/diff/
> 
> 
> Testing
> -------
> 
> Wrote/passed/failed unit tests; talked to myself so much to the point I swear I have mild schizophrenia now. 
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120911/5954d385/attachment-0001.html>