Review Request: [logviewer] Add actions to clear account and contact logs

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106229/#review18069
-----------------------------------------------------------

Ship it!


Fix the accountPtr comments before shipping.


logviewer/log-viewer.cpp
<http://git.reviewboard.kde.org/r/106229/#comment14310>

    We learned that Tp::AccountPtrs in the model can be null. Guard against this.



logviewer/log-viewer.cpp
<http://git.reviewboard.kde.org/r/106229/#comment14311>

    It's generally a bad idea to update the UI whilst deleting things.
    
    The ideal way of doing this is you call clearAccount, and then are notified from the backend that the data has been cleared which you monitor for.
    
    Otherwise if a remove fails, you still hide it, also if someone else clears the account you don't hide it.
    
    However I'm not sure there's a way to do this. Think about it for a little while and see if there's a better way before committing.


- David Edmundson


On Aug. 31, 2012, 10:53 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106229/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2012, 10:53 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add a popup menu to entity view. The menu has "Clear account history" and "Clear contact history" actions.
> 
> 
> This addresses bug 305762.
>     http://bugs.kde.org/show_bug.cgi?id=305762
> 
> 
> Diffs
> -----
> 
>   logviewer/entity-model-item.h e740d25 
>   logviewer/entity-model-item.cpp c7f2249 
>   logviewer/entity-model.h 205c132 
>   logviewer/entity-model.cpp cbee00a 
>   logviewer/log-viewer.h 4a9e20b 
>   logviewer/log-viewer.cpp 83d329c 
> 
> Diff: http://git.reviewboard.kde.org/r/106229/diff/
> 
> 
> Testing
> -------
> 
> Successfully destroyed all my logs
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120909/51492e43/attachment-0001.html>