Review Request: (2/3) Add "Join Chat Room" button to the presence applet

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104534/#review18702
-----------------------------------------------------------


This review has been submitted with commit 0e58920ab33e1a004b79428ec03ee57ff0a4873c by David Edmundson to branch master.

- Commit Hook


On Aug. 29, 2012, 8:29 p.m., Othmane Moustaouda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104534/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2012, 8:29 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Moving join chatroom dialog from contact-list to common-internals to make possible its use also by the presence applet
> 
> 
> This addresses bug 293207.
>     http://bugs.kde.org/show_bug.cgi?id=293207
> 
> 
> Diffs
> -----
> 
>   KTp/Models/CMakeLists.txt e6a65b4e66902eb759352cd225fe67053e8a766d 
>   KTp/Models/rooms-model.h PRE-CREATION 
>   KTp/Models/rooms-model.cpp PRE-CREATION 
>   KTp/Widgets/CMakeLists.txt 0dcf7c13ef7013afb94e3685f1925d59bece1833 
>   KTp/Widgets/join-chat-room-dialog.h PRE-CREATION 
>   KTp/Widgets/join-chat-room-dialog.cpp PRE-CREATION 
>   KTp/Widgets/join-chat-room-dialog.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104534/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Othmane Moustaouda
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120908/6d3391ff/attachment.html>