Review Request: Add context menu entry to modify contact notifications

[Heiko Tietze]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106353/#review18616
-----------------------------------------------------------


In my opinion the menu entry position is good as shown.

But you should not add ellipsis to these menu items. Ellipsis indicate that a command needs additional information. Functions to open another window don't take ellipsis.

- Heiko Tietze


On Sept. 6, 2012, 11:01 a.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106353/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2012, 11:01 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add context menu entry to modify contact notifications
> 
> The position of the configure entry is debatable, should it be at the bottom with "Show info" ? I'd like to hear your opinions :)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ffadc0bea1aa2cfd1f5222b06d2289775d0921ba 
>   context-menu.h 5a30c6d326c7401d7f226fdca1cb90b65d650403 
>   context-menu.cpp 10f3d90cc7de3c7ce5072d3a6dc449f9ecb8e721 
> 
> Diff: http://git.reviewboard.kde.org/r/106353/diff/
> 
> 
> Testing
> -------
> 
> Right click a contact > click "Configure Notifications" > Brings up notification configuration dialog
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/106353/s/716/
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120906/9c89edcc/attachment.html>