Review Request: Implement contact notifications

Thu Sep 6 11:11:09 UTC 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106355/
-----------------------------------------------------------

(Updated Sept. 6, 2012, 11:11 a.m.)

Review request for Telepathy.

Changes
-------

Minor styling fixup

Summary (updated)
-----------------

Implement contact notifications

Description (updated)
-------

Minor styling fixup

Make sure that the connection and contacts actually exist before doing anything

This change makes the code a bit more asynchronous and uses the right
eventID for notifications

Implement contact notifications

Diffs (updated)
-----

  CMakeLists.txt 96cedcff5a09eb26217b9032a68f4b4e01768805 
  contactnotify.h PRE-CREATION 
  contactnotify.cpp PRE-CREATION 
  telepathy-module.h 15666bcebf6d4b1d9640e016ff8d6202471b7629 
  telepathy-module.cpp 2085fea3d133db388e43c47ee8b0f3af8d5279cd 

Diff: http://git.reviewboard.kde.org/r/106355/diff/

Testing
-------

Notifications from specific contacts were shown.

Screenshots
-----------

  http://git.reviewboard.kde.org/r/106355/s/718/

Thanks,

Rohan Garg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120906/8d8fe655/attachment.html>