Review Request: So master isn't frozen anymore...

Tue Sep 4 13:31:41 UTC 2012

> On Aug. 19, 2012, 12:22 p.m., David Edmundson wrote:
> > filters/pipes/pipes-config.h, line 43
> > <http://git.reviewboard.kde.org/r/106083/diff/1/?file=78659#file78659line43>
> >
> >     This class isn't added.

I'm fairly certain I added it. ReviewBoard split this thing into two pages because there are so many files. 
https://git.reviewboard.kde.org/r/106083/diff/?page=2

> On Aug. 19, 2012, 12:22 p.m., David Edmundson wrote:
> > filters/bugzilla/CMakeLists.txt, line 14
> > <http://git.reviewboard.kde.org/r/106083/diff/1/?file=78643#file78643line14>
> >
> >     I assume this is copied and pasted from somewhere, if so where?
> >     
> >     I doubt any of the rest of this works on MacOS.

To be perfectly honest, I don't even remember where I took that from...

> On Aug. 19, 2012, 12:22 p.m., David Edmundson wrote:
> > filters/bugzilla/bugzilla-filter.cpp, line 61
> > <http://git.reviewboard.kde.org/r/106083/diff/1/?file=78645#file78645line61>
> >
> >     is that comment really helpful :P

If you parsed an entire JSON response in 1 line, what comment would you put? :P

> On Aug. 19, 2012, 12:22 p.m., David Edmundson wrote:
> > filters/bugzilla/bugzilla-filter.cpp, line 62
> > <http://git.reviewboard.kde.org/r/106083/diff/1/?file=78645#file78645line62>
> >
> >     I think the [0] can cause a crash if the list is empty/result in badly formatted.
> >     
> >

There, I replaced that beautiful line with a dozen more, that check at each step if the response is valid.

> On Aug. 19, 2012, 12:22 p.m., David Edmundson wrote:
> > filters/bugzilla/bugzilla-filter.cpp, line 65
> > <http://git.reviewboard.kde.org/r/106083/diff/1/?file=78645#file78645line65>
> >
> >     I would add a if (!description.isEmpty)
> >     
> >     otherwise we risk showing a 
> >     
> >     http://bugs.kde.org/show_bugs?id=
> >     
> >     which is empty.

If that happens, it would cause a bad response, which would cause the *new* parser/handler to not add anything.

> On Aug. 19, 2012, 12:22 p.m., David Edmundson wrote:
> > filters/highlight/ktptextui_message_filter_highlight.desktop, line 16
> > <http://git.reviewboard.kde.org/r/106083/diff/1/?file=78650#file78650line16>
> >
> >     This is actually running on both incoming and messages you send. Something that needs to be fixed.

Is there anything inherently wrong with you saying your own name?

- Lasath

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106083/#review17703
-----------------------------------------------------------

On Aug. 19, 2012, 10:29 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106083/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2012, 10:29 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Right, so here's a big fat review containing many many things, including all the remaining plugins and a few tweaks to Message.
> 
> As per usual, all the code is in my scratch repo: http://quickgit.kde.org/index.php?p=clones%2Fktp-text-ui%2Ffernando%2Fgsoc.git&a=summary
> 
> Now, I'm going to take a well earned nap.
> 
> 
> Diffs
> -----
> 
>   filters/substitution/substitution-filter.h PRE-CREATION 
>   filters/substitution/substitution-filter.cpp PRE-CREATION 
>   filters/substitution/substitution-prefs.h PRE-CREATION 
>   filters/substitution/substitution-prefs.cpp PRE-CREATION 
>   filters/youtube/CMakeLists.txt PRE-CREATION 
>   filters/youtube/ktptextui_message_filter_youtube.desktop PRE-CREATION 
>   filters/youtube/youtube-filter.h PRE-CREATION 
>   filters/youtube/youtube-filter.cpp PRE-CREATION 
>   lib/abstract-message-filter.h 7b60d48 
>   lib/abstract-message-filter.cpp 2a3a897 
>   lib/message.h ef9530b 
>   lib/message.cpp 6db648e 
>   tests/message-processor-basic-tests.h 7dc99e4 
>   tests/message-processor-basic-tests.cpp 8546605 
>   filters/pipes/pipes-prefs.h PRE-CREATION 
>   filters/pipes/pipes-prefs.cpp PRE-CREATION 
>   filters/pipes/pipes-prefstest.h PRE-CREATION 
>   filters/pipes/pipes-prefstest.cpp PRE-CREATION 
>   filters/substitution/CMakeLists.txt PRE-CREATION 
>   filters/substitution/kcm_ktp_filter_config_substitution.desktop PRE-CREATION 
>   filters/substitution/ktptextui_message_filter_substitution.desktop PRE-CREATION 
>   filters/substitution/substitution-config.h PRE-CREATION 
>   filters/substitution/substitution-config.cpp PRE-CREATION 
>   filters/substitution/substitution-config.ui PRE-CREATION 
>   filters/pipes/pipes-model.cpp PRE-CREATION 
>   filters/pipes/pipes-model.h PRE-CREATION 
>   filters/pipes/pipes-filter.cpp PRE-CREATION 
>   filters/pipes/pipes-filter.h PRE-CREATION 
>   filters/pipes/pipes-delegate.cpp PRE-CREATION 
>   filters/pipes/pipes-delegate.h PRE-CREATION 
>   filters/pipes/pipes-config.ui PRE-CREATION 
>   filters/pipes/CMakeLists.txt PRE-CREATION 
>   filters/pipes/kcm_ktp_filter_config_pipes.desktop PRE-CREATION 
>   filters/pipes/ktptextui_message_filter_pipes.desktop PRE-CREATION 
>   filters/pipes/pipes-config.h PRE-CREATION 
>   filters/pipes/pipes-config.cpp PRE-CREATION 
>   filters/latex/latex-filter.cpp PRE-CREATION 
>   filters/latex/ktptextui_message_filter_latex.desktop PRE-CREATION 
>   filters/latex/latex-filter.h PRE-CREATION 
>   filters/bugzilla/ktptextui_message_filter_bugzilla.desktop PRE-CREATION 
>   filters/highlight/CMakeLists.txt PRE-CREATION 
>   filters/highlight/highlight-filter.h PRE-CREATION 
>   filters/highlight/highlight-filter.cpp PRE-CREATION 
>   filters/highlight/ktptextui_message_filter_highlight.desktop PRE-CREATION 
>   filters/latex/CMakeLists.txt PRE-CREATION 
>   filters/latex/ktp_message_filter_latex_converter.sh PRE-CREATION 
>   filters/bugzilla/bugzilla-filter.cpp PRE-CREATION 
>   filters/CMakeLists.txt ee7c23d 
>   filters/bugzilla/CMakeLists.txt PRE-CREATION 
>   filters/bugzilla/bugzilla-filter.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106083/diff/
> 
> 
> Testing
> -------
> 
> Wrote/passed/failed unit tests; talked to myself so much to the point I swear I have mild schizophrenia now. 
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120904/aaf3d978/attachment-0001.html>