Review Request: So master isn't frozen anymore...

[Lasath Fernando]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106083/
-----------------------------------------------------------

(Updated Sept. 4, 2012, 1:31 p.m.)


Review request for Telepathy.


Changes
-------

Address issues raised about Bugzilla filter (and hopefully make it more secure as a side-effect). 

I'll do the other plugins some other day. 
And as for the missing classes, I think it's just because ReviewBoard splits the diff into two pages.


Description
-------

Right, so here's a big fat review containing many many things, including all the remaining plugins and a few tweaks to Message.

As per usual, all the code is in my scratch repo: http://quickgit.kde.org/index.php?p=clones%2Fktp-text-ui%2Ffernando%2Fgsoc.git&a=summary

Now, I'm going to take a well earned nap.


Diffs (updated)
-----

  filters/substitution/substitution-filter.h PRE-CREATION 
  filters/substitution/substitution-filter.cpp PRE-CREATION 
  filters/substitution/substitution-prefs.h PRE-CREATION 
  filters/substitution/substitution-prefs.cpp PRE-CREATION 
  filters/youtube/CMakeLists.txt PRE-CREATION 
  filters/youtube/ktptextui_message_filter_youtube.desktop PRE-CREATION 
  filters/youtube/youtube-filter.h PRE-CREATION 
  filters/youtube/youtube-filter.cpp PRE-CREATION 
  lib/abstract-message-filter.h 7b60d48 
  lib/abstract-message-filter.cpp 2a3a897 
  lib/message.h ef9530b 
  lib/message.cpp 6db648e 
  tests/message-processor-basic-tests.h 7dc99e4 
  tests/message-processor-basic-tests.cpp 8546605 
  filters/pipes/pipes-prefs.h PRE-CREATION 
  filters/pipes/pipes-prefs.cpp PRE-CREATION 
  filters/pipes/pipes-prefstest.h PRE-CREATION 
  filters/pipes/pipes-prefstest.cpp PRE-CREATION 
  filters/substitution/CMakeLists.txt PRE-CREATION 
  filters/substitution/kcm_ktp_filter_config_substitution.desktop PRE-CREATION 
  filters/substitution/ktptextui_message_filter_substitution.desktop PRE-CREATION 
  filters/substitution/substitution-config.h PRE-CREATION 
  filters/substitution/substitution-config.cpp PRE-CREATION 
  filters/substitution/substitution-config.ui PRE-CREATION 
  filters/pipes/pipes-model.cpp PRE-CREATION 
  filters/pipes/pipes-model.h PRE-CREATION 
  filters/pipes/pipes-filter.cpp PRE-CREATION 
  filters/pipes/pipes-filter.h PRE-CREATION 
  filters/pipes/pipes-delegate.cpp PRE-CREATION 
  filters/pipes/pipes-delegate.h PRE-CREATION 
  filters/pipes/pipes-config.ui PRE-CREATION 
  filters/pipes/CMakeLists.txt PRE-CREATION 
  filters/pipes/kcm_ktp_filter_config_pipes.desktop PRE-CREATION 
  filters/pipes/ktptextui_message_filter_pipes.desktop PRE-CREATION 
  filters/pipes/pipes-config.h PRE-CREATION 
  filters/pipes/pipes-config.cpp PRE-CREATION 
  filters/latex/latex-filter.cpp PRE-CREATION 
  filters/latex/ktptextui_message_filter_latex.desktop PRE-CREATION 
  filters/latex/latex-filter.h PRE-CREATION 
  filters/bugzilla/ktptextui_message_filter_bugzilla.desktop PRE-CREATION 
  filters/highlight/CMakeLists.txt PRE-CREATION 
  filters/highlight/highlight-filter.h PRE-CREATION 
  filters/highlight/highlight-filter.cpp PRE-CREATION 
  filters/highlight/ktptextui_message_filter_highlight.desktop PRE-CREATION 
  filters/latex/CMakeLists.txt PRE-CREATION 
  filters/latex/ktp_message_filter_latex_converter.sh PRE-CREATION 
  filters/bugzilla/bugzilla-filter.cpp PRE-CREATION 
  filters/CMakeLists.txt ee7c23d 
  filters/bugzilla/CMakeLists.txt PRE-CREATION 
  filters/bugzilla/bugzilla-filter.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/106083/diff/


Testing
-------

Wrote/passed/failed unit tests; talked to myself so much to the point I swear I have mild schizophrenia now. 


Thanks,

Lasath Fernando

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120904/413a258f/attachment.html>