Review Request: Add API to clear logs

Dan Vratil dan at progdan.cz
Sat Sep 1 13:32:22 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106228/
-----------------------------------------------------------

(Updated Sept. 1, 2012, 1:32 p.m.)


Review request for Telepathy and David Edmundson.


Changes
-------

As discussed with d_ed, this patch removes Tpl::Logger and moves it's clear*() methods to Tpl::LogManager. The actual implementation (the DBus calls) is in Tpl::PendingClear (renamed from Tpl::PendingLogger), which is not public.


Description
-------

Add three new methods to Tpl::LogManager to invoke telepathy-logger DBus methods for clearing logs.


Diffs (updated)
-----

  TelepathyLoggerQt4/CMakeLists.txt 7320581 
  TelepathyLoggerQt4/Logger c3f4164 
  TelepathyLoggerQt4/log-manager.h c245965 
  TelepathyLoggerQt4/log-manager.cpp e6acf40 
  TelepathyLoggerQt4/logger.h bf12cb1 
  TelepathyLoggerQt4/logger.cpp c1954d8 
  TelepathyLoggerQt4/pending-clear.h PRE-CREATION 
  TelepathyLoggerQt4/pending-clear.cpp PRE-CREATION 
  TelepathyLoggerQt4/pending-logger.h f2f32dd 
  TelepathyLoggerQt4/pending-logger.cpp 6d2a58b 
  TelepathyLoggerQt4/types.h c5f3f16 

Diff: http://git.reviewboard.kde.org/r/106228/diff/


Testing
-------

Works, be careful :)


Thanks,

Dan Vratil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120901/a9574122/attachment.html>


More information about the KDE-Telepathy mailing list