Review Request: Add API to clear logs

[David Edmundson]

> On Sept. 1, 2012, 4:52 a.m., David Edmundson wrote:
> > Awkward question. I was looking in the source code to check something, doesn't all this exist in PendingLogger?
> 
> Dan Vratil wrote:
>     It does, but Tpl::PendingLogger is not part of public API and requires Tpl::Logger which is not public either. Providing the API in Tpl::LogManager (by calling Tpl::PendingLogger) seems more logical to me because clearing logs == log management and also because we can simplify some calls for users (see Tpl::LogManager::clearEntityHistory()).

Ok, I agree your code is better. 
But having two sets of code in the source that does the same thing is clearly silly. As it wasn't public before, I suggest we delete both pendinglogger and logger.

Agree?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106228/#review18357
-----------------------------------------------------------


On Aug. 31, 2012, 10:45 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106228/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2012, 10:45 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Add three new methods to Tpl::LogManager to invoke telepathy-logger DBus methods for clearing logs.
> 
> 
> Diffs
> -----
> 
>   TelepathyLoggerQt4/log-manager.h c245965 
>   TelepathyLoggerQt4/log-manager.cpp e6acf40 
> 
> Diff: http://git.reviewboard.kde.org/r/106228/diff/
> 
> 
> Testing
> -------
> 
> Works, be careful :)
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120901/89b6fb0d/attachment.html>