Review Request: Fix receiving non-ASCII characters from ICQ

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106915/#review21226
-----------------------------------------------------------


When we are at it, maybe we could extend the list of encodings to support at least all ISO-8859-*, CP-125*, KOI* (russian) and GB* (chinese) charsets? 

I checked in Kopete and Adium, both have a long list of supported encodings. 


plugins/haze/icq-server-settings-widget.ui
<http://git.reviewboard.kde.org/r/106915/#comment16582>

    This probably shouldn't be part of this patch... :)


- Dan Vrátil


On Oct. 16, 2012, 6:09 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106915/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2012, 6:09 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Allow setting the Haze ICQ encoding to ISO-8859-1 in the UI.
> 
> Actually this is needed to workaround a potential bug in libpurple, so maybe this should be set by default (and not exposed to the user).
> 
> See Bug 306401 for details.
> 
> 
> This addresses bug 306401.
>     http://bugs.kde.org/show_bug.cgi?id=306401
> 
> 
> Diffs
> -----
> 
>   plugins/haze/icq-server-settings-widget.ui 6fe0a0a 
> 
> Diff: http://git.reviewboard.kde.org/r/106915/diff/
> 
> 
> Testing
> -------
> 
> Messages with German Umlauts, and Euro sign are received correctly now (once UTF-8 is changed to ISO-8859-1).
> Tested with ktp and an official ICQ client in a Windows VM
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121031/8e3c5620/attachment.html>