Review Request: Allow different handling of history messages and actions in the filters

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Tue Oct 30 05:58:25 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107095/
-----------------------------------------------------------

Review request for Telepathy, David Edmundson and Lasath Fernando.


Description
-------

Filters on actions are not executed, this is bad (for example see: https://bugs.kde.org/show_bug.cgi?id=309149)
Moreover it is impossible to execute a different filter for messages in the chat log, and this is also bad (for example see: https://bugs.kde.org/show_bug.cgi?id=309152)

This patch add a new set of methods to the Filters, in order to be able to filter actions and history.
Moreover these methods are used in the text to speech plugin.


This addresses bugs 309149 and 309152.
    http://bugs.kde.org/show_bug.cgi?id=309149
    http://bugs.kde.org/show_bug.cgi?id=309152


Diffs
-----

  lib/message-processor.cpp 44dc765e66f4e62b7b6425f053324b5e6fc4cedc 
  lib/logmanager.cpp 35700c035409ca350f44ee6b0d82b10fe11fb9cd 
  lib/message-processor.h c6183f688f7ec6f3306994dcc5564e3b8ea8d04f 
  lib/abstract-message-filter.cpp 798d33d50dde71bc3ed01de18cf407e6e2acc8d9 
  lib/chat-widget.cpp fb52ec2f00012a29a12fe4597175414b98c39cad 
  filters/texttospeech/tts-filter.cpp 2df979e2b3b452e7e3de3fcff24edbd144e12bee 
  lib/abstract-message-filter.h 2b159deb99f32483690ac9c4fb73a8f610063d99 
  filters/texttospeech/tts-filter.h ab4f74e555b84e087c1d67b3e8e265c4b3af04f9 

Diff: http://git.reviewboard.kde.org/r/107095/diff/


Testing
-------

Used in text to speech plugin, works


Thanks,

Daniele Elmo Domenichelli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121030/945ccf57/attachment.html>


More information about the KDE-Telepathy mailing list